doc: V8 branch used in 8.x not active anymore #18155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 8.x to the LTS versions that use a V8 branch that is not active anymore.
evanlucas
reviewed
Jan 15, 2018
| The versions of V8 used in Node.js v4.x and v6.x have already been abandoned by | ||
| upstream V8. However, Node.js needs to continue supporting these branches for | ||
| many months (Current branches) or several years (LTS branches). | ||
| The versions of V8 used in Node.js v4.x, v6.x, and 8.x have already been |
There was a problem hiding this comment.
should we make this consistent? Either 4.x, 6.x, and 8.x or v4.x, v6.x, and v8.x?
There was a problem hiding this comment.
Deliberately without the v, because starting with 8, we refer to Node as Node 8. But I'm happy to change it if we prefer consistency.
There was a problem hiding this comment.
ah yea, that's right. I'm indifferent :]
evanlucas
approved these changes
Jan 15, 2018
targos
approved these changes
Jan 15, 2018
|
@evanlucas hey, I'm new here and looking for ways to contribute to node, are you referring to the fact that naming conventions should be consistent? |
|
@Alweezy yes, that is what I was referring to. I had forgotten we had changed from v.x to .x due to possible confusion with the node v8 (version 8 of node) and V8 (the JavaScript engine). If you are interested in contributing to node, I would suggest starting off by looking through the issue list and looking specifically at https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22. Thanks! |
jasnell
approved these changes
Jan 15, 2018
mhdawson
reviewed
Jan 15, 2018
| The versions of V8 used in Node.js v4.x and v6.x have already been abandoned by | ||
| upstream V8. However, Node.js needs to continue supporting these branches for | ||
| many months (Current branches) or several years (LTS branches). | ||
| The versions of V8 used in Node.js v4.x, v6.x, and 8.x have already been |
There was a problem hiding this comment.
Does it make sense to list the versions and continually update? Wondering if we could just use some wording like "The versions of V8 used in Node.js have most often already been abanded by upstream V8."
lpinca
approved these changes
Jan 15, 2018
cjihrig
approved these changes
Jan 15, 2018
joyeecheung
added
the
author ready
|
Landed in 0c41782 |
addaleax
removed
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Jan 18, 2018
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: #18155 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: #18155 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: #18155 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: #18155 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: #18155 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: nodejs#18155 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 8.x to the LTS versions that use a V8 branch that is
not active anymore.
Affected core subsystem(s)
doc