-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: verify that a dependency cycle may exist #17968
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
http2
Issues or PRs related to the http2 subsystem.
test
Issues and PRs related to the tests.
labels
Jan 3, 2018
addaleax
approved these changes
Jan 3, 2018
jasnell
added a commit
that referenced
this pull request
Jan 5, 2018
PR-URL: #17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Landed in 22760f3 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
PR-URL: #17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
PR-URL: #17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
to jasnell/node
that referenced
this pull request
Jan 9, 2018
PR-URL: nodejs#17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This lands cleanly on v8.x but the test fails. Likely blocked by another backport
|
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17968 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple test to verify that a priority dependency cycle may exist but won't crash anything.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
http2