Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: properly handle already closed stream error #17942

Closed
wants to merge 2 commits into from
Closed

http2: properly handle already closed stream error #17942

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 2, 2018

HTTP/2 RFC requires connection to be torn down if the client attempts to use an already closed stream ID.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 2, 2018
@jasnell jasnell added the http2 Issues or PRs related to the http2 subsystem. label Jan 2, 2018
@jasnell
Copy link
Member Author

jasnell commented Jan 2, 2018

Ping @nodejs/http2

mcollina
mcollina approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

test/common/http2.js
array[pos] = val;
}

class Frame {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some comments on how to use these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jasnell jasnell force-pushed the http2-closed-stream branch from 6ac0bfd to f714aac Compare January 2, 2018 18:58
@jasnell
Copy link
Member Author

jasnell commented Jan 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12386/

@jasnell
Copy link
Member Author

jasnell commented Jan 3, 2018

CI is good

jasnell added a commit that referenced this pull request Jan 3, 2018
@jasnell
http2: properly handle already closed stream error
651ce28 
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell added a commit that referenced this pull request Jan 3, 2018
@jasnell
doc: add docs for common/http2.js utility
2f6d100 
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 3, 2018

Landed in 651ce28 and 2f6d100

@jasnell jasnell closed this Jan 3, 2018
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
http2: properly handle already closed stream error
06ed513 
PR-URL: nodejs#17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
doc: add docs for common/http2.js utility
e929bd0 
PR-URL: nodejs#17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
http2: properly handle already closed stream error
287d1ad 
Backport-PR-URL: #18050
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@jasnell @MylesBorins
doc: add docs for common/http2.js utility
4d7088e 
Backport-PR-URL: #18050
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@jasnell @MylesBorins
http2: properly handle already closed stream error
f17a5b9 
Backport-PR-URL: #18050
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@jasnell @MylesBorins
doc: add docs for common/http2.js utility
46f39b5 
Backport-PR-URL: #18050
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jan 24, 2018
Closed
3 tasks
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
http2: properly handle already closed stream error
3601bc4 
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
doc: add docs for common/http2.js utility
21c0a8c 
Backport-PR-URL: nodejs#18050
PR-URL: nodejs#17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
http2: properly handle already closed stream error
9a6ea7e 
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
doc: add docs for common/http2.js utility
35ee894 
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17942
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @mcollina @MylesBorins @nodejs-github-bot