perf_hooks: refactor internals #17822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and simplify the perf_hooks native internals.
jasnell
added
the
perf_hooks
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Dec 22, 2017
src/node_perf.cc
Outdated
| @@ -30,63 +29,106 @@ uint64_t performance_v8_start; | |||
| uint64_t performance_last_gc_start_mark_ = 0; | |||
| v8::GCType performance_last_gc_type_ = v8::GCType::kGCTypeAll; | |||
|
|
|||
| // Initialize the performance entry object properties | |||
| inline void InitObject(PerformanceEntry* entry, Local<Object> obj) { | |||
There was a problem hiding this comment.
const PerformanceEntry& entry? Makes it a bit more obvious which parameter is the source/target
src/node_perf.h
Outdated
|
|
||
| ~PerformanceEntry() {} | ||
| virtual Local<Object> ToObject(); |
There was a problem hiding this comment.
This could/should be const as well I think?
addaleax
added
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Dec 27, 2017
Refactor and simplify the perf_hooks native internals. PR-URL: #17822 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 9e5ccf0 |
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
Refactor and simplify the perf_hooks native internals. PR-URL: #17822 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Refactor and simplify the perf_hooks native internals. PR-URL: #17822 Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Refactor and simplify the perf_hooks native internals. PR-URL: #17822 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
|
Should this be backported to |
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Refactor and simplify the perf_hooks native internals. PR-URL: nodejs#17822 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and simplify the perf_hooks native internals.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
perf_hooks