Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: simplify onSelectPadding #17717

Closed
wants to merge 2 commits into from
Closed

http2: simplify onSelectPadding #17717

wants to merge 2 commits into from

Commits on Dec 17, 2017

  1. http2: simplify onSelectPadding 

    `OnCallbackPadding` on the native side already clamps
the return value into the right range, so there’s not need
to also do that on the JS side.

Also, use `>>> 0` instead of `| 0` to get an uint32, since
the communication with C++ land happens through an Uint32Array.
    @addaleax
    addaleax committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    5ee32f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. [squash] remove uint32 cast

    @addaleax
    addaleax committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    9e52c53 View commit details
    Browse the repository at this point in the history