Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-http-set-cookies to use Countdown #17550

Closed
wants to merge 1 commit into from
Closed

Update test-http-set-cookies to use Countdown #17550

wants to merge 1 commit into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Dec 8, 2017

Use Countdown class instead of nresponses in test-http-set-cookies.js

See also: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 8, 2017
@apapirovski
Copy link
Member

Hi @Leko, thanks for working on this — there already appears to be a PR that's approved and ready to get merged dealing with the same test: #17504

For the Countdown conversion tests, I would recommend searching the name of the file within PRs first as there has been a lot of progress on that end and the list in the referenced issue is outdated.

@Leko
Copy link
Contributor Author

Leko commented Dec 8, 2017

@apapirovski Thank you for information.
I closed this PR.

I would recommend searching the name of the file within PRs first

I got it.

@Leko Leko closed this Dec 8, 2017
@Leko Leko deleted the use_countdown_in_http-upgrade-server branch December 8, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants