New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor doc fixes #17502

Closed

Trott wants to merge 3 commits into nodejs:master from Trott:minor-doc-fixes

Member

Trott commented Dec 6, 2017

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

Trott added 3 commits

December 6, 2017 10:13


          doc: fix typo in dns.md

3c3daa5


          doc: fix common typo involving one-time listeners

57cd6fe

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.


          doc: fix typo in repl.md

298effc

nodejs-github-bot added the doc label

cjihrig approved these changes

View reviewed changes

richardlau approved these changes

View reviewed changes

apapirovski approved these changes

View reviewed changes

maclover7 approved these changes

View reviewed changes

Contributor

maclover7 commented Dec 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11923/

JungMinu approved these changes

View reviewed changes

lpinca approved these changes

View reviewed changes

Trott added a commit to Trott/io.js that referenced this pull request


          doc: fix typo in dns.md

86d386a

PR-URL: nodejs#17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request


          doc: fix common typo involving one-time listeners

de06dc9

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: nodejs#17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request


          doc: fix typo in repl.md

a413df4

PR-URL: nodejs#17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Member Author

Trott commented Dec 7, 2017

Landed in 86d386a, de06dc9, and a413df4.

Trott closed this

MylesBorins pushed a commit that referenced this pull request


          doc: fix typo in dns.md

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: fix common typo involving one-time listeners

d2b6fba

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: fix typo in repl.md

173a805

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: fix typo in dns.md

07df234

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: fix common typo involving one-time listeners

232a486

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          doc: fix typo in repl.md

b8141a4

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins mentioned this pull request

v9.3.0 proposal #17631

Merged

gibfahn pushed a commit that referenced this pull request


          doc: fix typo in dns.md

533cc5c

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn pushed a commit that referenced this pull request


          doc: fix common typo involving one-time listeners

069fd23

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn pushed a commit that referenced this pull request


          doc: fix typo in repl.md

d40c581

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn pushed a commit that referenced this pull request


          doc: fix common typo involving one-time listeners

a15da3b

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn pushed a commit that referenced this pull request


          doc: fix typo in repl.md

a44f085

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Member

gibfahn commented Dec 20, 2017

Didn't backport 86d386a to 6.x as there were conflicts.

gibfahn added the land-on-v6.x label

gibfahn added the land-on-v8.x label

gibfahn mentioned this pull request

v8.9.4 proposal #17772

Closed

gibfahn pushed a commit that referenced this pull request


          doc: fix typo in dns.md

25d7b8a

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn pushed a commit that referenced this pull request


          doc: fix common typo involving one-time listeners

07735b9

Our docs use both "one time listener" and "one-time listener". The
second is more correct. Standardize on that.

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn pushed a commit that referenced this pull request


          doc: fix typo in repl.md

2c327c6

PR-URL: #17502
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn mentioned this pull request

v8.9.4 proposal #17774

Merged

MylesBorins added the backported-to-v6.x label

MylesBorins mentioned this pull request

v6.12.3 proposal #17776

Merged

Trott deleted the minor-doc-fixes branch

January 13, 2022 22:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes

JungMinu JungMinu approved these changes

maclover7 maclover7 approved these changes

cjihrig cjihrig approved these changes

lpinca lpinca approved these changes

apapirovski apapirovski approved these changes

Labels

doc