docs: state decoding behavior for url pathname #1731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly states the fact that no decoding is performed on the url path or pathname or the query string by default in the URL module. Fixes #1538
silverwind
added
the
url
| @@ -72,7 +73,8 @@ Take a URL string, and return an object. | |||
| Pass `true` as the second argument to also parse the query string using the | |||
| `querystring` module. If `true` then the `query` property will always be | |||
| assigned an object, and the `search` property will always be a (possibly | |||
| empty) string. Defaults to `false`. | |||
| empty) string. If `false` then the neither the `query` nor the `search` | |||
There was a problem hiding this comment.
Please remove the superfluous 'the ' before 'neither'.
|
Looking good, except the typo. I think it's unnecessary to add it to |
| @@ -72,7 +73,8 @@ Take a URL string, and return an object. | |||
| Pass `true` as the second argument to also parse the query string using the | |||
| `querystring` module. If `true` then the `query` property will always be | |||
| assigned an object, and the `search` property will always be a (possibly | |||
| empty) string. Defaults to `false`. | |||
| empty) string. If `false` then the neither the `query` nor the `search` | |||
| properties will be parsed or decoded. Defaults to `false`. | |||
There was a problem hiding this comment.
By looking at the code I'm not really sure search is parsed at all?
Not too familiar with url code though.
There was a problem hiding this comment.
Good find, it looks like only query is decoded:
> url.parse('http://foo.com/?%26', true).search
'?%26'
> url.parse('http://foo.com/?%26', true).query
{ '&': '' }There was a problem hiding this comment.
Right, query is the decoded from the search field.
|
@silverwind removed the |
|
Thanks, landed in a74c2c9 |
This was referenced May 27, 2015
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Explicitly states the fact that no decoding is performed on the url path or pathname or the query string by default in the URL module. Fixes: nodejs/node#1538 PR-URL: nodejs/node#1731 Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Jul 27, 2020
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly states the fact that no decoding is performed on the url
path or pathname or the query string by default in the URL module.
@Fishrock123 should I also include a similar change in the
Http.ServerIncomingMessagesdocumentation as mentioned in the issue?Fixes #1538