Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: set maxHeaderListPairs in http2 headers benchmark #17194

Closed
wants to merge 1 commit into from
Closed

benchmark: set maxHeaderListPairs in http2 headers benchmark #17194

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

After the introduction of maxHeaderListPairs, the headers benchmark needs to be updated to set that value otherwise it fails on the last bench case with error code 11.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@apapirovski apapirovski added benchmark Issues and PRs related to the benchmark subsystem. http2 Issues or PRs related to the http2 subsystem. labels Nov 21, 2017
@apapirovski apapirovski requested a review from jasnell November 21, 2017 13:48
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http2 Issues or PRs related to the http2 subsystem. labels Nov 21, 2017
@apapirovski apapirovski removed the request for review from jasnell November 21, 2017 13:53
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

This shouldn't need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Nov 21, 2017
@apapirovski @jasnell
benchmark: set maxHeaderListPairs in h2 headers.js
f5352b3 
PR-URL: #17194
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in f5352b3

@jasnell jasnell closed this Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@apapirovski @MylesBorins
benchmark: set maxHeaderListPairs in h2 headers.js
b16d570 
PR-URL: #17194
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@apapirovski @gibfahn
benchmark: set maxHeaderListPairs in h2 headers.js
bf84ed0 
PR-URL: #17194
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@apapirovski @gibfahn
benchmark: set maxHeaderListPairs in h2 headers.js
3fe7f9f 
PR-URL: #17194
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apapirovski @jasnell @cjihrig @MylesBorins @gibfahn @nodejs-github-bot