Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix connectListener description in net docs #1717

Closed
wants to merge 1 commit into from
Closed

doc: fix connectListener description in net docs #1717

wants to merge 1 commit into from

Conversation

joshgummersall
Copy link

connectListener is registered as a listener to the 'connect' event
once. Update the documentation to reflect that behavior.

Fixes #901

`connectListener` is registered as a listener to the 'connect' event
once. Update the documentation to reflect that behavior.

Fixes #901
@mscdex mscdex added the doc Issues and PRs related to the documentations. label May 16, 2015
bnoordhuis pushed a commit that referenced this pull request May 17, 2015
`connectListener` is registered as a listener to the 'connect' event
once. Update the documentation to reflect that behavior.

Fixes: #901
PR-URL: #1717
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Cheers Josh, landed in fbaef40.

@bnoordhuis bnoordhuis closed this May 17, 2015
@Fishrock123
Copy link
Contributor

@joshgummersall curious, did you find this issue by the good first contribution tag, or somehow else? :)

@joshgummersall
Copy link
Author

@Fishrock123 using the tag! very nice idea and I will continue to cherry pick those issues when I can!

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
`connectListener` is registered as a listener to the 'connect' event
once. Update the documentation to reflect that behavior.

Fixes: nodejs/node#901
PR-URL: nodejs/node#1717
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net: wrong docs for socket 'connect' event registration
4 participants