Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined TSC. #1710

Closed
wants to merge 3 commits into from
Closed

Combined TSC. #1710

wants to merge 3 commits into from

Conversation

mikeal
Copy link
Contributor

@mikeal mikeal commented May 15, 2015

  • Adding node.js contributors to TSC.
  • Removing @isaacs from the TSC (he told us yesterday he was resigning because he's too buys CEOing)
  • Adding a section strictly for voting TSC members.

* **James M Snell** ([jasnell](https://github.com/jasnell)) <jasnell@gmail.com> (TSC)
* **Julien Gilli** ([misterdjules](https://github.com/misterdjules)) <jgilli@nodejs.org> (TSC)
* **Michael Dawson** ([mhdawson](https://github.com/mhdawson)) <michael_dawson@ca.ibm.com> (TSC)
* **Steven R Loomis** ([srl295](https://github.com/srl295)) <srloomis@us.ibm.com> (TSC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik Steven said he didn't need to be here since that would put IBM over the limit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my count was off, even without @isaacs we've got 13 people which puts 3 from IBM below the 1/4 limit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some @ in the nick links.

@Fishrock123
Copy link
Contributor

SGTM, it's a little out of practice to have someone else do it, but maybe we can get sign-off from everyone involved? (Or at least isaac, since he's leaving.)

@mikeal
Copy link
Contributor Author

mikeal commented May 15, 2015

@Fishrock123 good point, let's make sure that we get a +1 from @isaacs@srl295@orangemocha@jasnell@misterdjules@cjihrig✓ and @mhdawson

@cjihrig
Copy link
Contributor

cjihrig commented May 15, 2015

+1

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label May 15, 2015
@misterdjules
Copy link

+1

@jasnell
Copy link
Member

jasnell commented May 15, 2015

+1
On May 15, 2015 3:09 PM, "Julien Gilli" notifications@github.com wrote:

+1


Reply to this email directly or view it on GitHub
#1710 (comment).

@srl295
Copy link
Member

srl295 commented May 16, 2015

Hrm - +1 ish, but thought I should be under Collaborators instead of TSC to keep the counts right- right?

@jasnell
Copy link
Member

jasnell commented May 16, 2015

Ah, yes. Good point. Will three members from IBM put us over the limit? If
so, Steven should be (hopefully temporarily) moved to Collaborator (but
ideally invited as an observer to the TSC calls).
On May 15, 2015 5:08 PM, "Steven R. Loomis" notifications@github.com
wrote:

Hrm - +1 ish, but thought I should be under Collaborators instead of TSC
to keep the counts right- right?


Reply to this email directly or view it on GitHub
#1710 (comment).

@cjihrig
Copy link
Contributor

cjihrig commented May 16, 2015

This comment is on an outdated diff: #1710 (comment)

@mikeal said:

my count was off, even without @isaacs we've got 13 people which puts 3 from IBM below the 1/4 limit.

@jasnell
Copy link
Member

jasnell commented May 16, 2015

Oh! Well excellent news then!
On May 15, 2015 5:30 PM, "Colin Ihrig" notifications@github.com wrote:

This comment is on an outdated diff: #1710 (comment)
#1710 (comment)

@mikeal https://github.com/mikeal said:

my count was off, even without @isaacs https://github.com/isaacs we've
got 13 people which puts 3 from IBM below the 1/4 limit.


Reply to this email directly or view it on GitHub
#1710 (comment).

@srl295
Copy link
Member

srl295 commented May 16, 2015

@mikeal +1!

@orangemocha
Copy link
Contributor

@mikeal could you please put orangemocha@nodejs.org as my email address? Otherwise LGTM. Thanks!

@isaacs
Copy link
Contributor

isaacs commented May 18, 2015

+1, lgtm.

Should we also list my release GPG key, since it was used for a lot of old releases?

@Fishrock123
Copy link
Contributor

@isaacs yeah, that might be a good idea, we should probably list the keys for all prior releases that we can.

@mhdawson just awaiting sign-off from you. :)

@rvagg
Copy link
Member

rvagg commented May 19, 2015

@isaacs @Fishrock123 we need to make a separation between "authorized for release of this project" vs "keys for previous releases" I think, and if we're doing that then we should pull in keys for @misterdjules and @tjfontaine as well. However, note that this discussion is on the io.js repo where it's only @Fishrock123, @chrisdickinson and myself that have made releases so perhaps this is not the place to list them all?

@Fishrock123
Copy link
Contributor

Yeah, let's defer it for the converged repo.

@Fishrock123
Copy link
Contributor

@mhdawson could you please sign off on this? :D

@Fishrock123
Copy link
Contributor

(I'll merge it without his later today if he doesn't..)

@Fishrock123
Copy link
Contributor

Replaced by #2085

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Jul 16, 2015
These members were collaborators on the old joyent/node repo prior to
convergence of the Node.js and io.js projects under the Node
Foundation. This updates our list to represent that they are now also
part of the TSC (Technical Steering Committee), which was previously
known as the io.js TC.

PR-URL: nodejs#2085
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

Membership changes also previously reviewed by many more TSC & former
TC members in nodejs#1710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.