Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that docs must be built before make test #17096

Closed
wants to merge 1 commit into from
Closed

clarify that docs must be built before make test #17096

wants to merge 1 commit into from

Conversation

brettsheffield
Copy link

See comment in #16650

Running make test prior to running make doc results in this error:

added 3 packages and updated 1 package in 1.717s
/bin/sh: out/doc/api/console.html: No such file or directory
Makefile:579: recipe for target 'out/doc/api/console.html' failed
make[1]: *** [out/doc/api/console.html] Error 1
Makefile:213: recipe for target 'test' failed
make: *** [test] Error 2

After running make doc, make test succeeds.

This PR updates BUILDING.md to clarify.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 17, 2017
@joyeecheung
Copy link
Member

Sorry, this is not the intended behavior and should be fixed by #16661 ..

@brettsheffield
Copy link
Author

Ok. Thanks for clarifying @joyeecheung. If the intention is to fix the behavior, I'll close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants