Fix typos in the 9.2.0 changelog.

[LJNeon]

See #17061.

[refack]

@LJNeon welcome, and thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

P.S. If you have any question you can also feel free to contact me directly.

[refack]

Any objections to fast-track this?

[mscdex]

-1 The commit messages contain these typos, not solely the changelog. Changing them in here would cause an inconsistency. I believe in the past we've let these typos remain...

[gibfahn]

cc/ @nodejs/lts

Seems better to me to fix them here, we still have the commit hashes to link to the original commit messages.

[Fishrock123]

Pretty sure I've fixed commit messages in changelogs in the past. I certainly don't see any harm in it.

[gireeshpunathil]

• correcting mistakes when we spot them is nice to do
• The original messages cannot be corrected is a technical issue, need not hinder actionable corrections
• source code / links are in tact so the trackability is not lost at all

[benjamingr]

LGTM, the link still points to the original commit message.

[refack]

No "fast-track" as there is debate.

[evanlucas]

LGTM. Thanks for fixing. The commit message would need to be fixed upon landing

[gibfahn]

@mscdex are you still -1 on landing this?

[mscdex]

@gibfahn Yes. I also can't find evidence of commit message typos being fixed in the past, unless they were force pushed and there was no later fixup commit.

[sam-github]

I agree with @mscdex, while its unfortunate to have spelling and grammatical errors in the changelog, the commit messages and the changelog should not diverge.

We should be very careful to not land commit messages that we don't want to show up in the changelog.

[Trott]

What's the reasoning for wanting the commit message in the change log to always match that in the commit log down to every typo? I mean, I see why it's preferable on some quasi-aesthetic level, but if one says "mesage" and another says "message", what's the actual harm?

Not advocating either way. Truly want to understand the issue so I can weigh the benefits of fixing the typo (clarity; more professional text which rightly or wrongly reflects on the product when people read it) with leaving it (consistency with the commit message, but what's the benefit there?).

[vsemozhetbyt]

I can think of one tiny benefit: someone can search an exact message title in changelogs to find out what versions have adopted the commit. There may be many other ways to find it out, but someone may know only this simple one.

[apapirovski]

Would anyone like to bring this forward to the TSC or should we just close it?

(Personally I'm also -1 for reasons outlined in the comment above and will make it explicit if needed.)

[refack]

IMHO this falls under the mandate of @nodejs/release, but they might want to punt to the TSC.
Either way I think this should be codified.

[rvagg]

+1 for changing, we've done it on multiple occasions in the past and I'm fine with divergence since users are most likely to use the changelog as a reference.

[mcollina]

LGTM

[mhdawson]

Discussed in the TSC meeting week, open issue in Release repo to ask them to make the decision.

[BridgeAR]

Due to the concerns in the release group mentioned in nodejs/Release#307 I am going to close this.

@LJNeon thanks a lot for your contribution anyway! It is much appreciated and I am sorry that your work could not land.