Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir usage #16800

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir usage #16800

wants to merge 1 commit into from

Conversation

sastan
Copy link
Contributor

@sastan sastan commented Nov 6, 2017

use common/fixtures module instead

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@sastan
test: replace common.fixturesDir usage
d462302 
use `common/fixtures` module instead
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11219/

@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Nov 6, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
@sastan @Trott
test: replace common.fixturesDir usage
b55106f 
Use `common/fixtures` module instead in test-http2-client-upload.js

PR-URL: nodejs#16800
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Landed in b55106f

@Trott Trott closed this Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Thanks for the contribution! 🎉

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@sastan @cjihrig
test: replace common.fixturesDir usage
bcd818a 
Use `common/fixtures` module instead in test-http2-client-upload.js

PR-URL: nodejs#16800
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@sastan @MylesBorins
test: replace common.fixturesDir usage
7b14917 
Use `common/fixtures` module instead in test-http2-client-upload.js

PR-URL: #16800
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sastan @Trott @apapirovski @cjihrig @gireeshpunathil @mscdex @MylesBorins @nodejs-github-bot