tools: update to ESLint 4.10.0

[cjihrig]

Mostly wanted to try updating eslint because I haven't done it before.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

tools

[Trott]

Rubber-stamp LGTM assuming this was done with the tools/update-eslint.sh script.

[cjihrig]

assuming this was done with the tools/update-eslint.sh script.

It was. It's a nice script.

[maclover7]

@cjihrig Would I be able to talk you into writing a short maintaining-eslint.md guide like the one that's being worked on for npm.md, and the one that exists for V8? Obviously ESLint is not packaged for userland, but it's still a thing that needs to be updated from time to time.

[Trott]

@cjihrig Would I be able to talk you into writing a short maintaining-eslint.md guide like the one that's being worked on for npm.md, and the one that exists for V8? Obviously ESLint is not packaged for userland, but it's still a thing that needs to be updated from time to time.

The process for maintaining ESLint is documented in the form of the update-eslint.sh script. npm and V8 are considerably more complex as we ship with them etc. ESLint is just a build tool, so the script is sufficient. I suppose a guide, just in case someone is looking for it, that has 1-3 sentences pointing to the script would be 👍.

[maclover7]

The process for maintaining ESLint is documented in the form of the update-eslint.sh script. npm and V8 are considerably more complex as we ship with them etc. ESLint is just a build tool, so the script is sufficient. I suppose a guide, just in case someone is looking for it, that has 1-3 sentences pointing to the script would be 👍.

Yep, just a few sentences should be okay, not looking for an essay or anything :)

[cjihrig]

CI: https://ci.nodejs.org/job/node-test-pull-request/11214/

@maclover7 I'll submit a follow up PR.

[joyeecheung]

@maclover7 @cjihrig I think in the case of dependencies in tools, we should probably just document the updating process together because those are relatively no-fuss and don't need that many words to explain. (don't need to document them all at once tho, just suggesting we name it as something like maintaining-tools-dependencies.md and add more info later).

EDIT: although there are also gyp and icu which are a bit more compliated...but I still kinda want to see the guides in one place.

[MylesBorins]

This should be included in a larger backport of eslint to v6.x