[v8.x] doc: more accurate zlib windowBits information #16623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#14847 Original-PR-URL: nodejs#16511 Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Original-Reviewed-By: James M Snell <jasnell@gmail.com> Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Original-Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Original-Reviewed-By: Refael Ackermann <refack@gmail.com>
lpinca
approved these changes
Oct 30, 2017
|
Wow, thanks for being so quick on this. Quick question, you changed the fields in the commit message to I'm happy to change them back (already have on my local branch) if that's the correct thing to do, but I just want to make sure I'm not missing a trick 😁. |
|
@gibfahn I might be mixing things up, I know @MylesBorins corrected me on this once before, but generally do whatever you think is the right one :) |
gibfahn
pushed a commit
to gibfahn/node
that referenced
this pull request
Oct 30, 2017
Fixes: nodejs#14847 PR-URL: nodejs#16511 Backport-PR-URL: nodejs#16623 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
apapirovski
approved these changes
Oct 30, 2017
gibfahn
force-pushed
the
v8.x-staging
branch
4 times, most recently
from
b183192
to
fc8acc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14847
Original-PR-URL: #16511