Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove redundant error messages for assert.strictEqual() #16043

Closed
wants to merge 1 commit into from
Closed

test: remove redundant error messages for assert.strictEqual() #16043

wants to merge 1 commit into from

Conversation

chrissytina
Copy link

@chrissytina chrissytina commented Oct 6, 2017 •
edited by BridgeAR
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10674/

@Trott
Copy link
Member

Trott commented Oct 13, 2017

CI will have to be re-run. It's not running any subtasks.

@tniessen
Copy link
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/10699/

@joyeecheung
Copy link
Member

CI failures are unrelated. Landed in 3594223, thanks!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
@joyeecheung
test: remove redundant error messages
3594223 
Remove redundant error messages for assert.strictEqual()

PR-URL: #16043
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@addaleax
test: remove redundant error messages
89ebfc0 
Remove redundant error messages for assert.strictEqual()

PR-URL: nodejs/node#16043
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@targos
test: remove redundant error messages
24a0761 
Remove redundant error messages for assert.strictEqual()

PR-URL: #16043
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
test: remove redundant error messages
ae88690 
Remove redundant error messages for assert.strictEqual()

PR-URL: nodejs#16043
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@MylesBorins
test: remove redundant error messages
ebbd07d 
Remove redundant error messages for assert.strictEqual()

Backport-PR-URL: #19447
PR-URL: #16043
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chrissytina @joyeecheung @Trott @tniessen @jasnell @cjihrig @BridgeAR @nodejs-github-bot