Improved assert.ok error message #16028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule in test-https-agent-session-reuse.js
mscdex
added
dgram
Trott
added
the
code-and-learn
addaleax
approved these changes
Oct 7, 2017
|
btw, if #15993 lands first then the first commit here will go away when landing. :) |
BridgeAR
approved these changes
Oct 9, 2017
gibfahn
approved these changes
Oct 9, 2017
jasnell
approved these changes
Oct 9, 2017
|
CI run was good landing. |
|
Landed as e791057 |
mhdawson
pushed a commit
that referenced
this pull request
Oct 11, 2017
Update test-https-agent-session-reuse.js PR-URL: #16028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
@ppaugh For next time. take a look at how I updated the commit message to be in line with our contribution guidelines. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Update test-https-agent-session-reuse.js PR-URL: nodejs/node#16028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Update test-https-agent-session-reuse.js PR-URL: #16028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Update test-https-agent-session-reuse.js PR-URL: #16028 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test-dgram-send-empty-array.js, improved the message associated with the assert.ok to include the unexpected msg. Previously, this error message appeared to be a 'positive' message which seems contrary to the intent of the message parameter of the assert.ok() function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test