Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace fixturesDir with fixtures in https agent create connect… #15913

Closed
wants to merge 2 commits into from
Closed

test: replace fixturesDir with fixtures in https agent create connect… #15913

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6442a55
test: replace fixturesDir with fixtures in https agent create connect…
Greg-GB Oct 6, 2017
77fab8d
test: switch to use fixtures read key in http agent create connection…
Greg-GB Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/parallel/test-https-agent-create-connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');

Expand All @@ -9,11 +10,9 @@ const https = require('https');

const agent = new https.Agent();

const fs = require('fs');

const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`),
key: fixtures.readSync('keys/agent1-key.pem'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also can use fixtures.readKey.

cert: fixtures.readSync('keys/agent1-cert.pem'),
};

const expectedHeader = /^HTTP\/1\.1 200 OK/;
Expand Down