Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced https-socket-options test using fixtures #15882

Closed
wants to merge 4 commits into from
Closed

Replaced https-socket-options test using fixtures #15882

wants to merge 4 commits into from

Commits on Oct 6, 2017

  1. test: replaced fs.readSync with fixtures.readSync 

    NINA 2017 Code and Learn session for first time contributors.  This
touched test/parallel/test-https-socket-options.js to replace
common.fixturesDir
    Lam Chan committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    06cf9f2 View commit details
    Browse the repository at this point in the history

  2. test: optimizing the use of the fixtures library 

    changing calls from fixtures.readSync to fixtures.readKey where
applicable.
    Lam Chan committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    949ae1b View commit details
    Browse the repository at this point in the history

  3. test: fixed typo 

    fixed typo with pem key`
    Lam Chan committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    1b5a460 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2017

  1. [Squash] Fix nits

    @jasnell
    jasnell committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    1bfc2e9 View commit details
    Browse the repository at this point in the history