src: use pass by reference in module_wrap.cc #15591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes several pass by value arguments to pass by
reference. This change was motivated by the following Coverity
reports:
** CID 177292: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 326 in node::loader::<unnamed>::
check_file(node::url::URL, bool, bool)()
** CID 177293: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 352 in node::loader::<unnamed>::
resolve_extensions(node::url::URL, bool)()
*** CID 177290: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 368 in node::loader::<unnamed>::
resolve_index(node::url::URL)()
*** CID 177289: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 371 in node::loader::<unnamed>::
resolve_main(node::url::URL)()
*** CID 177291: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 430 in node::loader::<unnamed>::
resolve_directory(node::url::URL, bool)()
nodejs-github-bot
added
the
c++
addaleax
reviewed
Sep 24, 2017
| @@ -323,12 +323,12 @@ struct file_check { | |||
| bool failed = true; | |||
| uv_file file = -1; | |||
| }; | |||
| inline const struct file_check check_file(URL search, | |||
| inline const struct file_check check_file(URL* search, | |||
There was a problem hiding this comment.
I think none of the methods here in question actually modify the incoming parameter? In that case, just switching URL → const URL& would be nicer…
|
@cjihrig I’d suggest closing this in favour of @sam-github’s #15615 |
|
@cjihrig sorry Colin, I looked to see if someone had covered this, but missed your PR. I think I was looking too hard for URL in the subject. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes several pass by value arguments to pass by
reference. This change was motivated by the following Coverity
reports:
** CID 177292: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 326 in node::loader::::
check_file(node::url::URL, bool, bool)()
** CID 177293: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 352 in node::loader::::
resolve_extensions(node::url::URL, bool)()
*** CID 177290: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 368 in node::loader::::
resolve_index(node::url::URL)()
*** CID 177289: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 371 in node::loader::::
resolve_main(node::url::URL)()
*** CID 177291: Performance inefficiencies (PASS_BY_VALUE)
/src/module_wrap.cc: 430 in node::loader::::
resolve_directory(node::url::URL, bool)()
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src