Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x] deps: backport 071b655 from V8 upstream #15215

Closed
wants to merge 2 commits into from
Closed

[v6.x] deps: backport 071b655 from V8 upstream #15215

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 6, 2017

Original commit message:

[PATCH] [debugger] Scope iterator should not visit inner function literals.

R=marja@chromium.org
BUG=chromium:621361

Review-Url: https://codereview.chromium.org/2185913003
Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

/cc @nodejs/v8 @hashseed

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@targos
deps: backport 071b655 from V8 upstream
216d3a9 
Original commit message:

    [PATCH] [debugger] Scope iterator should not visit inner function literals.

    R=marja@chromium.org
    BUG=chromium:621361

    Review-Url: https://codereview.chromium.org/2185913003
    Cr-Commit-Position: refs/heads/master@{nodejs#38087}

Fixes: nodejs#15075
@nodejs-github-bot nodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Sep 6, 2017
@targos targos changed the title deps: backport 071b655 from V8 upstream [v6.x] deps: backport 071b655 from V8 upstream Sep 6, 2017
@targos
Copy link
Member Author

targos commented Sep 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10022/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/897/

/cc @nodejs/lts

mhdawson
mhdawson approved these changes Sep 11, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
@targos @MylesBorins
deps: backport 071b655 from V8 upstream
921876d 
Original commit message:

    [PATCH] [debugger] Scope iterator should not visit inner function literals.

    R=marja@chromium.org
    BUG=chromium:621361

    Review-Url: https://codereview.chromium.org/2185913003
    Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

PR-URL: #15215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins
Copy link
Contributor

landed in 921876d

@targos targos deleted the fix-15075 branch September 19, 2017 14:01
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @MylesBorins @fhinkel @jasnell @cjihrig @mhdawson @gibfahn @nodejs-github-bot