lib/child_process: convert to using internal/errors #15090
Conversation
nodejs-github-bot
added
child_process
lib/child_process.js
Outdated
| @@ -390,47 +391,47 @@ function normalizeSpawnArguments(file, args, options) { | |||
| if (options === undefined) | |||
| options = {}; | |||
| else if (options === null || typeof options !== 'object') | |||
| throw new TypeError('"options" argument must be an object'); | |||
| throw new errors.TypeError('ERR_OPTS_NOT_OBJECT'); | |||
There was a problem hiding this comment.
The existing ERR_INVALID_ARG_TYPE would be better here.
There was a problem hiding this comment.
(and else where throughout here)
There was a problem hiding this comment.
Thank you so much for doing this. I may be mistaken but I seem to recall another open PR that was looking at this file also. I'd recommend doing a quick search to make sure you're not accidentally duplicating effort. Either way, the work is deeply appreciated.
I left a couple of comments that should be addressed before this could proceed forward.
|
The other PR is here: #14998 |
|
They both change errors in |
jasnell
added
the
semver-major
|
so can i close this issue? |
|
Closing as this is a duplicate of another PR that is about to land. |
|
@ramimoshe thanks a lot for your work nevertheless! I am sorry that your PR could not land. |
covert lib/child_process.js over to using lib/internal/errors.js
ref: #11273