deps: upgrade libuv to 1.14.1 #14866

cjihrig · 2017-08-16T17:02:50Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

cjihrig · 2017-08-16T17:04:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9690/

refack

Rubberstamp

cjihrig · 2017-08-16T17:16:11Z

This appears to break test-setproctitle.js. My first guess is libuv/libuv#1396 for the culprit.

gibfahn · 2017-08-20T11:07:17Z

Should land with #14950 if backported to LTS.

refack · 2017-08-20T13:13:04Z

Sanity CI: https://ci.nodejs.org/job/node-test-commit-linuxone/8123/

cjihrig · 2017-08-20T14:49:26Z

A full CI run I started last night is here: https://ci.nodejs.org/job/node-test-commit/11914/

The second commit in this PR still needs to land and be released in libuv. The Windows failures here are addressed by #14950. Still looking into some other failures though.

cjihrig · 2017-08-20T15:46:57Z

@gibfahn any idea what's going on with https://ci.nodejs.org/job/node-test-commit-freebsd/11111/nodes=freebsd10-64/ ?

gibfahn · 2017-08-20T17:21:27Z

@gibfahn any idea what's going on with https://ci.nodejs.org/job/node-test-commit-freebsd/11111/nodes=freebsd10-64/ ?

Odd, seems to have just gotten stuck. I killed the job, cleaned up the processes, and rebooted. Hopefully that'll sort it.

XadillaX · 2017-08-21T02:54:11Z

Note it fixes #13581.

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: nodejs#14866 PR-URL: nodejs#14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: nodejs/node#14866 PR-URL: nodejs/node#14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

refack · 2017-08-27T20:40:43Z

And it fixes #12737

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: nodejs/node#14866 PR-URL: nodejs/node#14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: nodejs#12737 Fixes: nodejs#13581 Fixes: nodejs#15117 PR-URL: nodejs#14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig · 2017-09-06T14:19:48Z

New CI with libuv 1.14.1: https://ci.nodejs.org/job/node-test-pull-request/9960/

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes * build: * Snapshots are now re-enabled in V8 #14875 * console: * Implement minimal `console.group()`. #14910 * deps: * upgrade libuv to 1.14.1 #14866 * update nghttp2 to v1.25.0 #14955 * dns: * Add `verbatim` option to dns.lookup(). When true, results from the DNS resolver are passed on as-is, without the reshuffling that Node.js otherwise does that puts IPv4 addresses before IPv6 addresses. #14731 * fs: * add fs.copyFile and fs.copyFileSync which allows for more efficient copying of files. #15034 * inspector: * Enable async stack traces #13870 * module: * Add support for ESM. This is currently behind the `--experimental-modules` flag and requires the .mjs extension. `node --experimental-modules index.mjs` #14369 * napi: * implement promise #14365 * os: * Add support for CIDR notation to the output of the networkInterfaces() method. #14307 * perf_hooks: * An initial implementation of the Performance Timing API for Node.js. This is the same Performance Timing API implemented by modern browsers with a number of Node.js specific properties. The User Timing mark() and measure() APIs are implemented, as is a Node.js specific flavor of the Frame Timing for measuring event loop duration. #14680 * tls: * multiple PFX in createSecureContext [#14793](#14793) * Added new collaborators: * BridgeAR – Ruben Bridgewater PR-URL: #15308

Fixes: nodejs#12737 Fixes: nodejs#13581 Fixes: nodejs#15117 PR-URL: nodejs#14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes * build: * Snapshots are now re-enabled in V8 nodejs#14875 * console: * Implement minimal `console.group()`. nodejs#14910 * deps: * upgrade libuv to 1.14.1 nodejs#14866 * update nghttp2 to v1.25.0 nodejs#14955 * dns: * Add `verbatim` option to dns.lookup(). When true, results from the DNS resolver are passed on as-is, without the reshuffling that Node.js otherwise does that puts IPv4 addresses before IPv6 addresses. nodejs#14731 * fs: * add fs.copyFile and fs.copyFileSync which allows for more efficient copying of files. nodejs#15034 * inspector: * Enable async stack traces nodejs#13870 * module: * Add support for ESM. This is currently behind the `--experimental-modules` flag and requires the .mjs extension. `node --experimental-modules index.mjs` nodejs#14369 * napi: * implement promise nodejs#14365 * os: * Add support for CIDR notation to the output of the networkInterfaces() method. nodejs#14307 * perf_hooks: * An initial implementation of the Performance Timing API for Node.js. This is the same Performance Timing API implemented by modern browsers with a number of Node.js specific properties. The User Timing mark() and measure() APIs are implemented, as is a Node.js specific flavor of the Frame Timing for measuring event loop duration. nodejs#14680 * tls: * multiple PFX in createSecureContext [nodejs#14793](nodejs#14793) * Added new collaborators: * BridgeAR – Ruben Bridgewater PR-URL: nodejs#15308

MylesBorins · 2017-09-20T19:53:57Z

This should likely come with the libuv 1.14.0 upgrade if we do it in the next minor

/cc @nodejs/lts

Fishrock123 · 2017-09-20T19:57:19Z

This was only in a live release for a week though? seems like 1.14.1 at least should have more time.

cjihrig · 2017-09-20T20:29:09Z

There is no 1.14.0 update. We skipped directly to 1.14.1 because of a regression in uv_set_process_title().

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

libuv 1.14.0 includes a fix for the "%1 is not a valid Win32 application" error message. Refs: #14866 PR-URL: #14950 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable Changes: * assert: - assert.fail() can now take one or two arguments (Rich Trott) #12293 * crypto: - add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705 * deps: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade libuv to 1.15.0 (cjihrig) #15745 - upgrade libuv to 1.14.1 (cjihrig) #14866 - upgrade libuv to 1.13.1 (cjihrig) #14117 - upgrade libuv to 1.12.0 (cjihrig) #13306 * fs: - Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856 * inspector: - enable --inspect-brk (Refael Ackermann) #12615 * process: - add --redirect-warnings command line argument (James M Snell) #10116 * src: - allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028) - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932 - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172 - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677 * test: - remove common.fail() (Rich Trott) #12293 PR-URL: #16263

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Aug 16, 2017

refack approved these changes Aug 16, 2017

View reviewed changes

cjihrig mentioned this pull request Aug 16, 2017

unix,doc: always copy process title when setting libuv/libuv#1396

Closed

Daniel15 mentioned this pull request Aug 17, 2017

Add fs.copyFile for copying files, using uv_fs_copyfile #14906

Closed

cjihrig force-pushed the libuv branch from 2e04886 to 6ad7207 Compare August 20, 2017 02:56

cjihrig mentioned this pull request Aug 20, 2017

test: update windows module load error message #14950

Merged

3 tasks

jasnell approved these changes Aug 20, 2017

View reviewed changes

XadillaX mentioned this pull request Aug 21, 2017

os.networkInterfaces() returns wrong MAC addresses #13581

Closed

cjihrig mentioned this pull request Aug 25, 2017

fs: add fs.copyFile{Sync} #15034

Merged

4 tasks

refack mentioned this pull request Aug 27, 2017

Cannot open a folder under my OneDrive folder microsoft/vscode#27285

Closed

bzoz mentioned this pull request Aug 28, 2017

fs.lstatSync doesn't handle specific Windows REPARSE POINTS #12737

Closed

deps: upgrade libuv to 1.14.1

8485a7c

Fixes: nodejs#12737 Fixes: nodejs#13581 Fixes: nodejs#15117 PR-URL: nodejs#14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig force-pushed the libuv branch from 6ad7207 to 8485a7c Compare September 6, 2017 14:18

cjihrig changed the title ~~deps: upgrade libuv to 1.14.0~~ deps: upgrade libuv to 1.14.1 Sep 6, 2017

cjihrig merged commit 8485a7c into nodejs:master Sep 6, 2017

cjihrig deleted the libuv branch September 6, 2017 16:49

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017

deps: upgrade libuv to 1.14.1

5ce569c

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Sep 10, 2017

v8.5.0 proposal #15308

Merged

MylesBorins pushed a commit that referenced this pull request Sep 11, 2017

deps: upgrade libuv to 1.14.1

a9cfdea

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request Sep 12, 2017

deps: upgrade libuv to 1.14.1

acf9650

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added the lts-watch-v6.x label Sep 20, 2017

MylesBorins pushed a commit that referenced this pull request Oct 16, 2017

deps: upgrade libuv to 1.14.1

efc3530

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins pushed a commit that referenced this pull request Oct 25, 2017

deps: upgrade libuv to 1.14.1

08d6830

Fixes: #12737 Fixes: #13581 Fixes: #15117 PR-URL: #14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: upgrade libuv to 1.14.1 #14866

deps: upgrade libuv to 1.14.1 #14866

cjihrig commented Aug 16, 2017

cjihrig commented Aug 16, 2017

refack left a comment

cjihrig commented Aug 16, 2017

gibfahn commented Aug 20, 2017

refack commented Aug 20, 2017

cjihrig commented Aug 20, 2017

cjihrig commented Aug 20, 2017

gibfahn commented Aug 20, 2017

XadillaX commented Aug 21, 2017

refack commented Aug 27, 2017

cjihrig commented Sep 6, 2017

MylesBorins commented Sep 20, 2017

Fishrock123 commented Sep 20, 2017

cjihrig commented Sep 20, 2017

deps: upgrade libuv to 1.14.1 #14866

deps: upgrade libuv to 1.14.1 #14866

Conversation

cjihrig commented Aug 16, 2017

Checklist

Affected core subsystem(s)

cjihrig commented Aug 16, 2017

refack left a comment

Choose a reason for hiding this comment

cjihrig commented Aug 16, 2017

gibfahn commented Aug 20, 2017

refack commented Aug 20, 2017

cjihrig commented Aug 20, 2017

cjihrig commented Aug 20, 2017

gibfahn commented Aug 20, 2017

XadillaX commented Aug 21, 2017

refack commented Aug 27, 2017

cjihrig commented Sep 6, 2017

MylesBorins commented Sep 20, 2017

Fishrock123 commented Sep 20, 2017

cjihrig commented Sep 20, 2017