tools: fix update-eslint.sh #14850
Merged
tools: fix update-eslint.sh #14850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't fail for me |
|
Fail vs. not fail perhaps dependent on whether or not you are using a recent |
|
@MylesBorins can you post the error that you get? |
That is certainly incorrect as the empty directory is created just a few lines above. If anything, the script assumes the directory is empty. I just tested with a few npm versions going back to 2.15.11 and can't replicate a problem. Definitely interested in seeing the error you're getting... |
|
npm's default behavior is to search up the file system for a package.json, I probably have an erroneous package.json somewhere on the filesystem. I think it is good to be explicit here |
|
Confirmed! |
|
Does it help to run the command with |
cjihrig
approved these changes
Aug 16, 2017
|
I don't believe that will make a difference
|
targos
approved these changes
Aug 17, 2017
MylesBorins
force-pushed
the
fix-update-eslint
branch
from
207f82a
to
11146a3
Compare
The script currently assumes that there is a package.json in `eslint-tmp`. If there isn't the logic of the script fails. This adds a call to `npm init --yes` ensuring there is a package.json and that the script can do it's thing. PR-URL: nodejs#14850 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins
force-pushed
the
fix-update-eslint
branch
from
11146a3
to
fb73256
Compare
|
landed in fb73256 |
MylesBorins
added a commit
that referenced
this pull request
Sep 10, 2017
The script currently assumes that there is a package.json in `eslint-tmp`. If there isn't the logic of the script fails. This adds a call to `npm init --yes` ensuring there is a package.json and that the script can do it's thing. PR-URL: #14850 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Merged
MylesBorins
added a commit
that referenced
this pull request
Sep 12, 2017
The script currently assumes that there is a package.json in `eslint-tmp`. If there isn't the logic of the script fails. This adds a call to `npm init --yes` ensuring there is a package.json and that the script can do it's thing. PR-URL: #14850 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
Sep 20, 2017
The script currently assumes that there is a package.json in `eslint-tmp`. If there isn't the logic of the script fails. This adds a call to `npm init --yes` ensuring there is a package.json and that the script can do it's thing. PR-URL: #14850 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script currently assumes that there is a package.json in
eslint-tmp. If there isn't the logic of the script fails.This adds a call to
npm init --yesensuring there is a package.jsonand that the script can do it's thing.