Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove unused parameters #14526

Closed
wants to merge 1 commit into from
Closed

benchmark: remove unused parameters #14526

wants to merge 1 commit into from

Conversation

mnalsup
Copy link
Contributor

@mnalsup mnalsup commented Jul 28, 2017

Functions completeConfig, completeRun, and
updateProgress had unused parameters. These
were removed.

Checklist
  • [ x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines
Affected core subsystem(s)

Benchmark

@mnalsup
benchmark: remove unused parameters
fb29bbf 
Functions completeConfig, completeRun, and
updateProgress had unused parameters. These
were removed.
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Jul 28, 2017
Trott
Trott approved these changes Jul 28, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Jul 28, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9385/

@Trott
Copy link
Member

Trott commented Aug 1, 2017

Landed in 859ccd7

@Trott Trott closed this Aug 1, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 1, 2017
@mnalsup @Trott
benchmark: remove unused parameters
859ccd7 
Functions completeConfig, completeRun, and
updateProgress had unused parameters. These
were removed.

PR-URL: nodejs#14526
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 1, 2017

Thanks for the contribution! 🎉

addaleax pushed a commit that referenced this pull request Aug 1, 2017
@mnalsup @addaleax
benchmark: remove unused parameters
0cf1e22 
Functions completeConfig, completeRun, and
updateProgress had unused parameters. These
were removed.

PR-URL: #14526
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mnalsup @Trott @jasnell @evanlucas @lpinca @TimothyGu @cjihrig @tniessen @MylesBorins @nodejs-github-bot