Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace assert with CHECK_LE in node_api.cc #14514

Merged
merged 2 commits into from
Aug 7, 2017
Merged

src: replace assert with CHECK_LE in node_api.cc #14514

merged 2 commits into from
Aug 7, 2017

Commits on Aug 7, 2017

  1. src: replace assert with CHECK_LE in node_api.cc 

    PR-URL: nodejs#14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
    @bnoordhuis
    bnoordhuis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    f3afe29 View commit details
    Browse the repository at this point in the history

  2. src: remove unused Connection::ClearError() 

    PR-URL: nodejs#14514
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
    @bnoordhuis
    bnoordhuis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    e658d32 View commit details
    Browse the repository at this point in the history