[v6.x backport] test: change deprecated method to recommended #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. PR-URL: nodejs#13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
2 tasks
mscdex
added
stream
refack
approved these changes
Jul 18, 2017
|
landed in 34fc7a0 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 18, 2017
In non-buffer tests, change usage of the Buffer constructor to one of the recommended alternatives. Backport-PR-URL: #14339 PR-URL: #13649 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.
PR-URL: #13649
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Brian White mscdex@mscdex.net
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)