(v8.x backport) benchmark,lib,test: use braces for multiline block #13995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For if/else and loops where the bodies span more than one line, use curly braces. PR-URL: nodejs#13828 Ref: nodejs#13623 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
inspector
2 tasks
|
CI just to be on the safe side: https://ci.nodejs.org/job/node-test-pull-request/8886/ |
addaleax
pushed a commit
that referenced
this pull request
Jun 30, 2017
For if/else and loops where the bodies span more than one line, use curly braces. Original-PR-URL: #13828 Ref: #13623 (comment) Original-Reviewed-By: Anna Henningsen <anna@addaleax.net> Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Original-Reviewed-By: Michaël Zasso <targos@protonmail.com> Original-Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #13995 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed on v8.x-staging @ 8152383 |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 30, 2017
For if/else and loops where the bodies span more than one line, use curly braces. Original-PR-URL: #13828 Ref: #13623 (comment) Original-Reviewed-By: Anna Henningsen <anna@addaleax.net> Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Original-Reviewed-By: Michaël Zasso <targos@protonmail.com> Original-Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #13995 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
For if/else and loops where the bodies span more than one line, use curly braces. Original-PR-URL: #13828 Ref: #13623 (comment) Original-Reviewed-By: Anna Henningsen <anna@addaleax.net> Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Original-Reviewed-By: Michaël Zasso <targos@protonmail.com> Original-Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #13995 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
For if/else and loops where the bodies span more than one line, use curly braces. Original-PR-URL: #13828 Ref: #13623 (comment) Original-Reviewed-By: Anna Henningsen <anna@addaleax.net> Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Original-Reviewed-By: Michaël Zasso <targos@protonmail.com> Original-Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #13995 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For if/else and loops where the bodies span more than one line, use
curly braces.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
bookmark lib test