test: refactor indexOf uses to es6 equivalents #13853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
approved these changes
Jun 21, 2017
vsemozhetbyt
approved these changes
Jun 21, 2017
mscdex
reviewed
Jun 21, 2017
test/pummel/test-dtrace-jsstack.js
Outdated
| continue; | ||
|
|
||
| const frame = line.substr(line.indexOf(sentinel) + sentinel.length); | ||
| const top = frames.shift(); | ||
|
|
||
| assert.strictEqual(frame.indexOf(top), 0, | ||
| assert.ok(frame.startsWith(top) === true, |
There was a problem hiding this comment.
The === true part can be left out here.
test/pummel/test-dtrace-jsstack.js
Outdated
| continue; | ||
|
|
||
| const frame = line.substr(line.indexOf(sentinel) + sentinel.length); | ||
| const top = frames.shift(); | ||
|
|
||
| assert.strictEqual(frame.indexOf(top), 0, | ||
| assert.ok(frame.startsWith(top) === true, | ||
| `unexpected frame where ${top} was expected`); |
There was a problem hiding this comment.
It is now linter issue:
96:24 error Expected indentation of 14 spaces but found 23 indent-legacy
cjihrig
approved these changes
Jun 21, 2017
refactor indexOf uses to es6 where applicable Refs: nodejs#12586
|
I've fixed the rejects, how do i make the CI run again? |
jasnell
approved these changes
Jun 22, 2017
aqrln
approved these changes
Jun 22, 2017
|
I think these changes were already covered in #13852 (amongst others) 😕 . Thank you for your contribution, I am sorry these changes did not make it in. Keep up the good work! |
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor indexOf uses to es6 where applicable
Refs: #12586
#goodnessSquad