Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smalloc: do not track external memory #1375

Closed
wants to merge 2 commits into from
Closed

smalloc: do not track external memory #1375

wants to merge 2 commits into from

Commits on Apr 8, 2015

  1. smalloc: do not track external memory 

    The memory that was allocated outside of the `smalloc.cc` should not be
tracked using `AdjustAmountOfExternalAllocatedMemory`. There are no
potential issues except triggering V8's GC way too often.

In fact, `heap.js` is creating a buffer out of the pointer, and since it
doesn't know the size of the pointer - it just creates the maximum
possible `Buffer` instance with a no-op free callback and no hint.
    @indutny
    indutny committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    1407d99 View commit details
    Browse the repository at this point in the history

  2. fix

    @indutny
    indutny committed Apr 8, 2015
    Configuration menu
    Copy the full SHA
    48134dd View commit details
    Browse the repository at this point in the history