Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add newline in --help message #13315

Closed
wants to merge 1 commit into from
Closed

src: add newline in --help message #13315

wants to merge 1 commit into from

Conversation

JoshFerge
Copy link

@JoshFerge JoshFerge commented May 30, 2017 •
edited
Loading

In the current node.js 8.0.0 release, there is a missing newline in the --help command line flag message. I've added a newline where appropriate. Screenshots attached showing the change.
before:
screen shot 2017-05-30 at 3 22 26 pm
after:
screen shot 2017-05-30 at 3 40 15 pm

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 30, 2017
jasnell
jasnell approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh!

@JoshFerge JoshFerge changed the title Added Newline in Help Message src: add newline in --help message May 31, 2017
@jasnell
Copy link
Member

jasnell commented Jun 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8419/

jasnell pushed a commit that referenced this pull request Jun 1, 2017
@jasnell
src: added newline in help message
7f545f0 
PR-URL: #13315
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 1, 2017

Landed in 7f545f0

@jasnell jasnell closed this Jun 1, 2017
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@jasnell
src: added newline in help message
8620aad 
PR-URL: #13315
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JoshFerge @jasnell @MylesBorins @refack @addaleax @Fishrock123 @targos @cjihrig @nodejs-github-bot