Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: back-port openbsd build fix #1318

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Conversation

bnoordhuis
Copy link
Member

Cherry-pick https://codereview.chromium.org/856553002 from upstream.

Refs: #1312

R=@indutny? /cc @kaspars @qbit

@indutny
Copy link
Member

indutny commented Apr 1, 2015

LGTM

@indutny
Copy link
Member

indutny commented Apr 1, 2015

Could you please put up some details for posterity?

@bnoordhuis
Copy link
Member Author

You mean in the commit log? There's not much to the patch but I'll add a line explaining it fixes macro definitions.

@indutny
Copy link
Member

indutny commented Apr 1, 2015

@bnoordhuis I mean: what exactly does it fix and why is this is a problem only on OpenBSD?

@rvagg
Copy link
Member

rvagg commented Apr 1, 2015

/cc @jbergstroem

@bnoordhuis
Copy link
Member Author

@indutny V8 was picking up the wrong V8_INT64_C and V8_UINT64_C macros on openbsd/amd64. I confess I don't understand why numeric literals need to be long long instead of just long on that platform but it's needed on OS X as well and I don't understand that either. :-)

@mscdex mscdex added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 1, 2015
@jbergstroem
Copy link
Member

I actually ran into this just yesterday while exploring OpenBSD's make. Confirmed working for 64-bit builds. 32-bit builds still bails for me -- looking into it now.

(as a side-note for OpenBSD developers, the libuv test suite could be improved).

Edit: Adding LGTM

Cherry-pick https://codereview.chromium.org/856553002 from upstream.

Makes V8 on OpenBSD/amd64 pick up the right V8_INT64_C and V8_UINT64_C
macros.

PR-URL: nodejs#1318
Refs: nodejs#1312
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@bnoordhuis bnoordhuis closed this Apr 1, 2015
@bnoordhuis bnoordhuis deleted the v8-openbsd-fix branch April 1, 2015 22:28
@bnoordhuis bnoordhuis merged commit 382bd9d into nodejs:v1.x Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants