test: shorten test-benchmark-http #13109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--set key=""` to cut down the time it takes to run test-benchmark-http by about a third. Alphabetize options in `--set` list.
Trott
added
benchmark
refack
approved these changes
May 18, 2017
joyeecheung
approved these changes
May 19, 2017
cjihrig
approved these changes
May 19, 2017
mhdawson
approved these changes
May 19, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 22, 2017
Add `--set key=""` to cut down the time it takes to run test-benchmark-http by about a third. Alphabetize options in `--set` list. PR-URL: nodejs#13109 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 171a43a |
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Add `--set key=""` to cut down the time it takes to run test-benchmark-http by about a third. Alphabetize options in `--set` list. PR-URL: #13109 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
May 23, 2017
Add `--set key=""` to cut down the time it takes to run test-benchmark-http by about a third. Alphabetize options in `--set` list. PR-URL: #13109 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
3 tasks
This was referenced Jun 21, 2023
This was referenced Jun 21, 2023
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--set key=""to cut down the time it takes to runtest-benchmark-http by about a third.
Alphabetize options in
--setlist.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark http