Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) build: don't create directory for NDK toolchain #12975

Closed
wants to merge 1 commit into from
Closed

(v6.x backport) build: don't create directory for NDK toolchain #12975

wants to merge 1 commit into from

Conversation

diastremskii
Copy link
Contributor

Starting from commit 90561a... in NDK make-standalone-toolchain.sh requires --force option to write toolchain into existing directory and will fail with Refusing to clobber existing install directory otherwise.
But with --force option script will fail on older versions of NDK. So best option should be just let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@diastremskii
build: don't create directory for NDK toolchain
7bf2253 
Let make-standalone-toolchain.sh create directory.

PR-URL: nodejs#11916
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label May 11, 2017
jasnell
jasnell approved these changes May 11, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

MylesBorins pushed a commit that referenced this pull request May 16, 2017
@diastremskii @MylesBorins
build: don't create directory for NDK toolchain
b179b26 
Let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Backport-PR-URL: #12975
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

landed in b179b26

@diastremskii diastremskii deleted the backport-11916-to-v6.x branch May 16, 2017 05:32
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@diastremskii @MylesBorins
build: don't create directory for NDK toolchain
a0973c3 
Let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Backport-PR-URL: #12975
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@diastremskii @andrew749
build: don't create directory for NDK toolchain
835aad8 
Let make-standalone-toolchain.sh create directory.

PR-URL: nodejs/node#11916
Backport-PR-URL: nodejs/node#12975
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diastremskii @MylesBorins @jasnell @mscdex @nodejs-github-bot