Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add common.mustCall() to NAPI exception test #12959

Closed
wants to merge 1 commit into from
Closed

test: add common.mustCall() to NAPI exception test #12959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/addons-napi/test_exception/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ function throwTheError() {
}
let caughtError;

const throwNoError = common.noop;

// Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError,
Expand All @@ -34,13 +32,13 @@ assert.strictEqual(test_exception.wasPending(), true,
' when it was allowed through');

// Test that the native side does not capture a non-existing exception
returnedError = test_exception.returnException(throwNoError);
returnedError = test_exception.returnException(common.mustCall());
assert.strictEqual(undefined, returnedError,
'Returned error is undefined when no exception is thrown');

// Test that no exception appears that was not thrown by us
try {
test_exception.allowException(throwNoError);
test_exception.allowException(common.mustCall());
} catch (anError) {
caughtError = anError;
}
Expand Down