Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-vm-is-context.js : changed the assert.thows object to regex and … #12785

Closed
wants to merge 5 commits into from
Closed

test-vm-is-context.js : changed the assert.thows object to regex and … #12785

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b788dd
test-vm-is-context.js : changed the assert.thows object to regex and …
Jeyanthinath May 2, 2017
6c199ca
vm: changed the error from constructor to regular expression
Jeyanthinath May 2, 2017
96fe0d8
vm: changed the error from constructor to regular expression
Jeyanthinath May 2, 2017
ade9260
test: add regex check in test-vm-is-context
Jeyanthinath May 2, 2017
3a52e21
Merge branch 'master' of https://github.com/Jeyanthinath/node
Jeyanthinath May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions test/parallel/test-vm-is-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,16 @@ const vm = require('vm');

assert.throws(function() {
vm.isContext('string is not supported');
}, TypeError);
}, /TypeError/);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this to: /^TypeError: sandbox must be an object$/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did changed ! thanks


assert.strictEqual(vm.isContext({}), false);
assert.strictEqual(vm.isContext([]), false);

assert.strictEqual(vm.isContext(vm.createContext()), true);
assert.strictEqual(vm.isContext(vm.createContext([])), true);

const sandbox = { foo: 'bar' };
vm.createContext(sandbox);
assert.strictEqual(vm.isContext(sandbox), true);
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reasons to add this block.

Copy link
Contributor Author

@Jeyanthinath Jeyanthinath May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would restrict the access of sandbox variable. @lpinca any suggestion ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful if you want to reuse the sandbox variable in another scope but currently there is no need for it.

Copy link
Contributor

@mscdex mscdex May 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it really matters either way, but I personally would probably opt to just wait until someone adds another test below it that also uses variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok , I will revoke it as of now

const sandbox = { foo: 'bar' };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeyanthinath please revert also these white space changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops , I missed those , thanks !

vm.createContext(sandbox);
assert.strictEqual(vm.isContext(sandbox), true);
}