Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: warn about --without-ssl disabling debugger #12768

Closed
wants to merge 2 commits into from
Closed

build: warn about --without-ssl disabling debugger #12768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a158b2
build: require `--without-debugger` explicitly
refack Apr 30, 2017
38fca5b
[squash] change disable to load warning
refack May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,11 +1296,18 @@ def configure_intl(o):
pprint.pformat(icu_config, indent=2) + '\n')
return # end of configure_intl

def configure_inspector(o):
disable_inspector = (options.without_inspector or
options.with_intl in (None, 'none') or
options.without_ssl)
o['variables']['v8_enable_inspector'] = 0 if disable_inspector else 1
def configure_debugger(o):
implicit_disable = (options.with_intl in (None, 'none') or
options.without_ssl)
if implicit_disable and not options.without_inspector:
options.without_inspector = True
print('********************* Warning *************************')
print('Setting --without_ssl or --without-intl will disable the')
print('`inspector` protocol. Ever since the removal of the `debug`')
print('protocol this is the only available debugger API, so it will leave')
print('the binary with no debug interface.')
print('*********************************************************')
o['variables']['v8_enable_inspector'] = 0 if options.without_inspector else 1

output = {
'variables': {},
Expand Down Expand Up @@ -1332,7 +1339,7 @@ configure_v8(output)
configure_openssl(output)
configure_intl(output)
configure_static(output)
configure_inspector(output)
configure_debugger(output)

# variables should be a root level element,
# move everything else to target_defaults
Expand Down