Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: make console consistent with the standard - overridable #12454

Closed

Commits on Aug 15, 2017

  1. console: make console consistent with the standard - overridable

    make console overridable by custom console( without delete )
    add test suite from w3c/web-platform-tests( console-is-a-namespace )
    few test cases commented out from the test suite
    to make nodejs console even more consistent further changes needed
    which will come in the next commit
    which could be more breaking than this one
    
    Fixes: nodejs#11805
    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    ea237b2 View commit details
    Browse the repository at this point in the history
  2. console: make console consistent - writable, not enumerable

    according to the standard
    property descriptor of console
    should be writable, have value and be not enumerable
    adjust test suite imported from w3c/web-platform-tests( console-is-a-namespace )
    one test case still is commented out from the test suite
    to make nodejs console even more consistent further changes needed
    which will come in the next commit
    which could be more breaking than this one
    
    Fixes: nodejs#11805
    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    d98c130 View commit details
    Browse the repository at this point in the history
  3. console: add WPT footer as requested

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    4a0669d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fad6725 View commit details
    Browse the repository at this point in the history
  5. console : add WPT header as requested

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    6e86bca View commit details
    Browse the repository at this point in the history
  6. console: take care of console set undefined case

    If global.console write undefined would come earlier than global.console read
    then lazy read in get would happen, despite write was done.
    This commit fix the problem.
    
    Fixes: nodejs#11805
    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    79dc629 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e10a6dd View commit details
    Browse the repository at this point in the history
  8. console : fix typo

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    28c32a2 View commit details
    Browse the repository at this point in the history
  9. console : few more test cases

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    02768c0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5f9d30f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bb26718 View commit details
    Browse the repository at this point in the history
  12. console : fix jsling issue

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    352d504 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    197ec07 View commit details
    Browse the repository at this point in the history
  14. console : => shorthand

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    c653812 View commit details
    Browse the repository at this point in the history
  15. console : requested comment

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    5a411bc View commit details
    Browse the repository at this point in the history
  16. console : requested comment

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    c9c572a View commit details
    Browse the repository at this point in the history
  17. console : requested comment

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    b553b49 View commit details
    Browse the repository at this point in the history
  18. console : requested comment

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    b7d9771 View commit details
    Browse the repository at this point in the history
  19. console : requested comment

    Wandalen authored and Trott committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    8023728 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2017

  1. squash: update test-console-is-a-namespace

    Update the test from the most recent WPT contents. Copyedit some
    existing comments.
    Trott committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    490374f View commit details
    Browse the repository at this point in the history
  2. squash: rename test

    Trott committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    2f43d8d View commit details
    Browse the repository at this point in the history