-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: make console consistent with the standard - overridable #12454
Closed
Wandalen
wants to merge
21
commits into
nodejs:master
from
Wandalen:console-consistent-with-standard
Closed
console: make console consistent with the standard - overridable #12454
Wandalen
wants to merge
21
commits into
nodejs:master
from
Wandalen:console-consistent-with-standard
Commits on Aug 15, 2017
-
console: make console consistent with the standard - overridable
make console overridable by custom console( without delete ) add test suite from w3c/web-platform-tests( console-is-a-namespace ) few test cases commented out from the test suite to make nodejs console even more consistent further changes needed which will come in the next commit which could be more breaking than this one Fixes: nodejs#11805
Configuration menu - View commit details
-
Copy full SHA for ea237b2 - Browse repository at this point
Copy the full SHA ea237b2View commit details -
console: make console consistent - writable, not enumerable
according to the standard property descriptor of console should be writable, have value and be not enumerable adjust test suite imported from w3c/web-platform-tests( console-is-a-namespace ) one test case still is commented out from the test suite to make nodejs console even more consistent further changes needed which will come in the next commit which could be more breaking than this one Fixes: nodejs#11805
Configuration menu - View commit details
-
Copy full SHA for d98c130 - Browse repository at this point
Copy the full SHA d98c130View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0669d - Browse repository at this point
Copy the full SHA 4a0669dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fad6725 - Browse repository at this point
Copy the full SHA fad6725View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e86bca - Browse repository at this point
Copy the full SHA 6e86bcaView commit details -
console: take care of console set undefined case
If global.console write undefined would come earlier than global.console read then lazy read in get would happen, despite write was done. This commit fix the problem. Fixes: nodejs#11805
Configuration menu - View commit details
-
Copy full SHA for 79dc629 - Browse repository at this point
Copy the full SHA 79dc629View commit details -
Configuration menu - View commit details
-
Copy full SHA for e10a6dd - Browse repository at this point
Copy the full SHA e10a6ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28c32a2 - Browse repository at this point
Copy the full SHA 28c32a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02768c0 - Browse repository at this point
Copy the full SHA 02768c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f9d30f - Browse repository at this point
Copy the full SHA 5f9d30fView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb26718 - Browse repository at this point
Copy the full SHA bb26718View commit details -
Configuration menu - View commit details
-
Copy full SHA for 352d504 - Browse repository at this point
Copy the full SHA 352d504View commit details -
Configuration menu - View commit details
-
Copy full SHA for 197ec07 - Browse repository at this point
Copy the full SHA 197ec07View commit details -
Configuration menu - View commit details
-
Copy full SHA for c653812 - Browse repository at this point
Copy the full SHA c653812View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a411bc - Browse repository at this point
Copy the full SHA 5a411bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9c572a - Browse repository at this point
Copy the full SHA c9c572aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b553b49 - Browse repository at this point
Copy the full SHA b553b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7d9771 - Browse repository at this point
Copy the full SHA b7d9771View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8023728 - Browse repository at this point
Copy the full SHA 8023728View commit details
Commits on Aug 16, 2017
-
squash: update test-console-is-a-namespace
Update the test from the most recent WPT contents. Copyedit some existing comments.
Configuration menu - View commit details
-
Copy full SHA for 490374f - Browse repository at this point
Copy the full SHA 490374fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f43d8d - Browse repository at this point
Copy the full SHA 2f43d8dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.