Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.x backport: test: refactor several parallel/test-timer tests #12401

Closed

Conversation

BethGriggs
Copy link
Member

Change var to const/let. Simplify test-timers-uncaught-exception.

PR-URL: #10524
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

/cc @gibfahn

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Apr 13, 2017
@sam-github
Copy link
Contributor

@lpinca lpinca changed the title test: refactor several parallel/test-timer tests v6.x backport: test: refactor several parallel/test-timer tests Apr 13, 2017
@lpinca
Copy link
Member

lpinca commented Apr 13, 2017

@BethGriggs I took the liberty of updating PR title.

@mscdex mscdex added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. and removed backport-to-v6.x labels Apr 13, 2017
@MylesBorins
Copy link
Contributor

so it seems like the work from this PR ended up getting wrapped into another backport that has already landed. Thanks for putting the time into this @BethGriggs, fun to run into you in the PR tracker 😄

@gibfahn
Copy link
Member

gibfahn commented Apr 18, 2017

@MylesBorins Is that true? The changes to the first file were just var->const, and they went into a different PR, but the changes to the other files don't seem to have gone into v6.x-staging, e.g. test-timers-uncaught-exception.js on v6.x-staging.

e.g. this diff:

-console.error('set first timer');
-setTimeout(function() {
-  console.error('first timer');
-  timer1++;
-  throw new Error('BAM!');
-}, 100);
+setTimeout(common.mustCall(function() {
+  throw new Error(errorMsg);
+}), 1);

isn't in test-timers-uncaught-exception.js#L10-L15.

@gibfahn gibfahn reopened this Apr 18, 2017
Change var to const/let. Simplify test-timers-uncaught-exception.

PR-URL: nodejs#10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@gibfahn
Copy link
Member

gibfahn commented Apr 18, 2017

@gibfahn
Copy link
Member

gibfahn commented Apr 19, 2017

MylesBorins pushed a commit that referenced this pull request Apr 24, 2017
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins
Copy link
Contributor

landed in 9218661

MylesBorins pushed a commit that referenced this pull request Apr 24, 2017
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: nodejs/node#12401
PR-URL: nodejs/node#10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@BethGriggs BethGriggs deleted the backport-10524-to-v6.x branch February 21, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants