build: --without-ssl implies --without-inspector #12200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
thefourtheye
approved these changes
Apr 4, 2017
MylesBorins
force-pushed
the
v6.x-staging
branch
from
59b869e to
078188d
Compare
jasnell
approved these changes
Apr 4, 2017
This cherry-picks the changes to `configure` from commit 8f00455 ("inspector: switch to new inspector APIs") from the master branch and should unbreak `--without-ssl` builds. Refs: nodejs#12155
bnoordhuis
force-pushed
the
configure-inspector-v6.x
branch
from
6a86fb5 to
b61b2e9
Compare
|
Rebased and new CI for good measure: https://ci.nodejs.org/job/node-test-pull-request/7332/ |
richardlau
approved these changes
Apr 11, 2017
cjihrig
approved these changes
Apr 11, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Apr 13, 2017
This cherry-picks the changes to `configure` from commit 8f00455 ("inspector: switch to new inspector APIs") from the master branch and should unbreak `--without-ssl` builds. Refs: #12155 PR-URL: #12200 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
landed in 17963a5 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
This cherry-picks the changes to `configure` from commit 8f00455 ("inspector: switch to new inspector APIs") from the master branch and should unbreak `--without-ssl` builds. Refs: #12155 PR-URL: #12200 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
This cherry-picks the changes to `configure` from commit 8f00455 ("inspector: switch to new inspector APIs") from the master branch and should unbreak `--without-ssl` builds. Refs: nodejs/node#12155 PR-URL: nodejs/node#12200 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the changes to
configurefrom commit 8f00455("inspector: switch to new inspector APIs") from the master branch
and should unbreak
--without-sslbuilds.Refs: #12155