test: add case for url.parse throwing a URIError #12135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
requested changes
Mar 30, 2017
| @@ -16,3 +16,5 @@ const url = require('url'); | |||
| ].forEach(function(val) { | |||
| assert.throws(function() { url.parse(val); }, TypeError); | |||
| }); | |||
|
|
|||
| assert.throws(function() { url.parse('http://%E0%A4%A@fail'); }, URIError); | |||
There was a problem hiding this comment.
Can you change the last parameter to assert.throws() to /^URIError: URI malformed$/.
The auth property of a URL is decoded via decodeURIComponent, which can throw a URIError. The test URL here will trigger this. Adds documentation on the possible errors url.parse can throw.
refack
approved these changes
Mar 30, 2017
mscdex
added
doc
joyeecheung
approved these changes
Mar 31, 2017
There was a problem hiding this comment.
Still not sure if it's OK for Node.js to throw an URIError (because qsEscape is not a global URI handling function, even it is intended as a fast alternative for encodeURIComponent), but the test and the doc are definitely appreciated :)
jasnell
approved these changes
Mar 31, 2017
cjihrig
approved these changes
Mar 31, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 4, 2017
The auth property of a URL is decoded via decodeURIComponent, which can throw a URIError. The test URL here will trigger this. Adds documentation on the possible errors url.parse can throw. PR-URL: #12135 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 2ff107d |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, the
url.parsefunction usesdecodeURIComponent, which can throw aURIError, to parse theauthproperty of a URL. The example included here will test this path.This PR also adds documentation on the possible errors that
url.parsecan throw. I'm happy to move this to a separate PR should this make things easier/cleaner.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, doc