src: allow inspector to be run on ephemeral port

[sam-github]

Its impossible to know in general whether any specific port will be
available or not, so its quite useful to run the inspector on an
ephemeral port, chosen by the operating system from its free ports.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[eugeneo]

This will also change behavior of the debugger (e.g. --debug flag). Is this expected?

[sam-github]

Interesting, the --debug option is completely undocumented, other than it being mentioned that it exists in the online docs (its not mentioned in the --help output for any node from 0.10 to 7.x).

But I would expect 0 to be valid there, and I just tried, and it works fine.

[eugeneo]

I think it would be nice to switch inspector tests to use :0 port and to have a dedicated test case to test default or explicitly specified port - this way it will be easier to run tests in parallel.

Also, CI test failures seem to be caused by this PR.

[gibfahn]

have a dedicated test case to test default or explicitly specified port

Default --inspect port test: deps/node-inspect/test/node-inspect.test.js

There is currently only 1 --inspect test in sequential/: test/sequential/test-debugger-debug-brk.js

[sam-github]

I'm still working through the tests, I've a slow machine.

I agree that this feature may allow a number of the sequential tests to be run in parallel, but that should be done in a follow up, not here.

[richardlau]

cc @nodejs/diagnostics

[bnoordhuis]

Way ahead of you, Sam: #5025 :-) Unfortunately, the CI is as red there as it is here.

[eugeneo]

(I must admit I have a local branch with this fix as well - but never uploaded it because I never gotten to fixing the tests ;) )

…

On Tue, Mar 28, 2017 at 9:47 AM Ben Noordhuis ***@***.***> wrote: Way ahead of you, Sam: #5025 <#5025> :-) Unfortunately, the CI is as red there as it is here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12093 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARkrUaSyhATJrjPgyD4FHymyHWdKq6Yks5rqTmjgaJpZM4MrxhE> .