Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add missing #include "unicode/putil.h" #12078

Closed
wants to merge 0 commits into from
Closed

tools: add missing #include "unicode/putil.h" #12078

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 27, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows
Affected core subsystem(s)
  • tools

@srl295 srl295 added wip Issues and PRs that are still a work in progress. i18n-api Issues and PRs related to the i18n implementation. labels Mar 27, 2017
@srl295 srl295 self-assigned this Mar 27, 2017
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 27, 2017
@srl295
Copy link
Member Author

srl295 commented Mar 27, 2017

needed for ICU 59 bump: #12077

cjihrig
cjihrig approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you mention, in the commit log, the function that is used.

@srl295
Copy link
Member Author

srl295 commented Mar 29, 2017

@cjihrig thanks, done and rebased.

@srl295 srl295 removed the wip Issues and PRs that are still a work in progress. label Mar 30, 2017
@srl295 srl295 closed this Mar 30, 2017
srl295 added a commit that referenced this pull request Mar 30, 2017
@srl295
tools: add missing #include "unicode/putil.h"
b084907 
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@srl295 srl295 deleted the fix-iculslocs branch March 30, 2017 22:10
@srl295
Copy link
Member Author

srl295 commented Mar 30, 2017 •
edited
Loading

Landed in b084907

@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@srl295 @italoacasas
tools: add missing #include "unicode/putil.h"
fdf76d5 
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to nodejs#11753

PR-URL: nodejs#12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
@MylesBorins
Copy link
Contributor

@srl295 lts?

@gibfahn
Copy link
Member

gibfahn commented May 16, 2017

@srl295 given this:

no impact on past ICUs.

Does that mean that this isn't necessary on v6.x?

@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

ping @srl295

2 similar comments
@MylesBorins
Copy link
Contributor

ping @srl295

@MylesBorins
Copy link
Contributor

ping @srl295

@srl295
Copy link
Member Author

srl295 commented Aug 14, 2017 •
edited
Loading

☹️ sorry, yes ,it should be backported if we want to use ICU 59 on past Nodes.
So its not necessary, but it can be helpful.

MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@srl295 @MylesBorins
tools: add missing #include "unicode/putil.h"
cbd2c77 
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@srl295 @MylesBorins
tools: add missing #include "unicode/putil.h"
74d5cba 
* we use u_setDataDirectory() in "unicode/putil.h"
* at present, this header is indirectly included,
  but this will change in ICU 59
* no impact on past ICUs.
* this is an exact analog to #11753

PR-URL: #12078
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins added a commit that referenced this pull request Sep 5, 2017
@MylesBorins
2017-09-05, Version 6.11.3 'Boron' (LTS)
dbce2ec 
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   #14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   #14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   #14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   #12078

PR-URL: #14852
MylesBorins added a commit that referenced this pull request Sep 5, 2017
@MylesBorins
2017-09-05, Version 6.11.3 'Boron' (LTS)
dc7f03c 
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   #14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   #14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   #14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   #12078

PR-URL: #14852
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@MylesBorins @addaleax
2017-09-05, Version 6.11.3 'Boron' (LTS)
83f797b 
This LTS release comes with 152 commits. This includes 75 which are
test related, 25 which are doc related, 21 which are build / tool
related and 3 commits which are updates to dependencies.

Notable Changes:

* build:
 - Codesigning is fixed on macOS (Evan Lucas)
   nodejs#14179
* deps:
 - Snapshots are turned back on!!! (Yang Guo)
   nodejs#14385
* path:
 - win32 volume-relative paths are working again! (Timothy Gu)
   nodejs#14440
* tools:
 - v6.x can now build with ICU 59 (Steven R. Loomis)
   nodejs#12078

PR-URL: nodejs#14852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srl295 @MylesBorins @gibfahn @jasnell @cjihrig @richardlau @nodejs-github-bot