Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: require uses fs root for '/' prefix #11897

Closed
wants to merge 1 commit into from
Closed

doc: require uses fs root for '/' prefix #11897

wants to merge 1 commit into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Mar 17, 2017

Fixes: #7151

Checklist
Affected core subsystem(s)

doc

@bmeck bmeck added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 17, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Mar 17, 2017
@bmeck bmeck mentioned this pull request Mar 17, 2017
Closed
vsemozhetbyt
vsemozhetbyt reviewed Mar 17, 2017
View reviewed changes
doc/api/modules.md
2. If X begins with './' or '/' or '../'
2. If X begins with '/'
a. set Y to be the filesystem root
3. If X begins with './' or '/' or '../'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be just 'If X begins with './' or '../'' now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since we still want to do 3.a. and 3.b. even if 2. is taken

jasnell pushed a commit that referenced this pull request Mar 22, 2017
@bmeck @jasnell
doc: require uses fs root for '/' prefix
757ff80 
PR-URL: #11897
Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

Landed in 757ff80

@jasnell jasnell closed this Mar 22, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@bmeck @MylesBorins
doc: require uses fs root for '/' prefix
486bd1b 
PR-URL: #11897
Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@bmeck @MylesBorins
doc: require uses fs root for '/' prefix
b4f6fc0 
PR-URL: #11897
Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@bmeck @MylesBorins
doc: require uses fs root for '/' prefix
3ad0a14 
PR-URL: #11897
Fixes: #7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@bmeck @andrew749
doc: require uses fs root for '/' prefix
2322e06 
PR-URL: nodejs/node#11897
Fixes: nodejs/node#7151
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module resolution description does not reflect the implementation
6 participants
@bmeck @jasnell @cjihrig @vsemozhetbyt @MylesBorins @nodejs-github-bot