test: include all stdio strings for fork() #11783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
child_process
lpinca
reviewed
Mar 10, 2017
|
|
||
| assert.throws(() => fork(childScript, malFormedOpts), errorRegexp); | ||
|
|
||
| const child = fork(childScript, stringOpts); | ||
| function test(stringVariant) { | ||
| const child = fork(childScript, {stdio: 'pipe'}); |
There was a problem hiding this comment.
The options object should be {stdio: stringVariant}.
jasnell
approved these changes
Mar 10, 2017
test-child-process-fork-stdio-string-variant was only testing 'pipe' for its `stdio` value. Add `inherit` and `ignore`. Also added a `common.mustCall()` to verify that the `message` event is triggered.
lpinca
approved these changes
Mar 10, 2017
santigimeno
approved these changes
Mar 10, 2017
|
Landed in 78cdd4b |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 13, 2017
test-child-process-fork-stdio-string-variant was only testing 'pipe' for its `stdio` value. Add `inherit` and `ignore`. Also added a `common.mustCall()` to verify that the `message` event is triggered. PR-URL: nodejs#11783 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
This is not landing clearly in |
|
@italoacasas This depends on #10866 which is semver-major. Adding |
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
test-child-process-fork-stdio-string-variant was only testing 'pipe' for its `stdio` value. Add `inherit` and `ignore`. Also added a `common.mustCall()` to verify that the `message` event is triggered. PR-URL: nodejs#11783 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-child-process-fork-stdio-string-variant was only testing 'pipe' for
its
stdiovalue. Addinheritandignore.Also added a
common.mustCall()to verify that themessageevent istriggered.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test child_process