Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: remove misleading comment #11573

Closed
wants to merge 1 commit into from

Commits on Feb 27, 2017

  1. net: remove misleading comment

    The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor
    to use streams2") from 2012 but it wasn't true even then as far as I
    can tell: Node.js simply always does a shutdown(2) first.
    
    It is true that streams2 withholds the 'end' event when allowHalfOpen
    is true but the comment is about a callback that hangs off the 'finish'
    event that is emitted after calling `socket.end()`.
    bnoordhuis committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    2cfa4e2 View commit details
    Browse the repository at this point in the history