Make test-require-resolve case insensitive #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copyOnto is broken when one argument has 1 byte size and the other > 1 byte. PR-URL: nodejs/node-v0.x-archive#8637 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Make the root_certs global fully const. As a side effect, that moves it from the .data section to the .rodata section. Makes it a little easier to reason about the remaining globals.
There is not much point in keeping it a separate project because it doesn't build standalone, plus it makes applying changes to core more difficult because of the implicit dependency on header files in src/.
Drop the trailing nullptr and use ARRAY_SIZE.
Update the debug agent to conform to the code style in src/.
When started with IPC pipe on fd=0 child process should not crash when referencing or using `process.stdin`. fix nodejs/node-v0.x-archive#8669 PR-URL: node-forward/node#45 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Newer incarnations of the task manager only show the description, not even the product name. PR-URL: node-forward/node#46 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuisl.nl>
PR-URL: nodejs/node-v0.x-archive#8655 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
This change in V8: https://code.google.com/p/v8/source/detail?r=22210 has introduced a method named OS::GetCurrentThreadId which fails to compile on OSes where a "gettid" syscall does not exist. This build issue has been fixed upstream by several changes: - https://code.google.com/p/v8/source/detail?r=23459. - https://codereview.chromium.org/649553002 - https://codereview.chromium.org/642223003 Another minor fix to the upstream changes was also necessary. See https://code.google.com/p/v8/issues/detail?id=3620 for more information. The other build issue was due to the fact that alloca.h is not included by other system includes on SmartOS, which is assumed by V8. Built and tested on Linux, MacOS X, Windows and SmartOS.
Fixes a bug that was introduced in commit f674b09 when v8::String::New() calls were replaced with calls to one-byte, two-byte and UTF-8 versions. It turns out that for network interface names, using a one-byte encoding can produce the wrong results on Windows. Use UTF-8 instead. Libuv on Windows correctly encodes non-ASCII characters in the interface name as UTF-8. On Unices however, the interface name is just a binary string with no particular encoding; that's why on UNIX platforms, we keep interpreting it as a one-byte string. Fixes nodejs/node-v0.x-archive#8633. PR-URL: node-forward/node#44 Reviewed-By: Bert Belder <bertbelder@gmail.com>
Add a .spec file and a rpmbuild(1) driver script. Useful for people on RHEL-based systems that want to compile and package from source. PR-URL: node-forward/node#10 Reviewed-By: Rod Vagg <rod@vagg.org>
Unlink NODE_COMMON_PIPE before running the test if set in the environment. The test runner won't do it for us like it does for files in test/tmp. PR-URL: node-forward/node#40 Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: node-forward/node#50 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: nodejs/node-v0.x-archive#8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: nodejs/node-v0.x-archive#8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
It was modified in libuv to be consistent with uv_exepath and not include the trailing NULL byte in the returned size. PR-URL: nodejs/node-v0.x-archive#8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Revert uv_thread_self() to return unsigned long instead of uv_thread_t. This was causing a build failure on Windows and is only a temporary fix until the proper patch lands upstream. Reverts: joyent/libuv@59658a8 Fixes: ce112c2 "deps: update uv to v1.0.0-rc2"
pending tls.TLSSocket growing the ability to work with streams, createSecurePair will remain. PR-URL: nodejs/node-v0.x-archive#8695 Reviewed-by: Fedor Indutny <fedor@indutny.com>
Vulnerability credit goes to:
Calvin Liang conradjliang@hotmail.com
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: ...private
Reviewed-By: Fedor Indutny <fedor@indutny.com> PR-URL: nodejs/node-v0.x-archive#6442
Killing the cluster master first on Windows causes an ESRCH when killing the children as the OS takes care of them itself. PR-URL: node-forward/node#53 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
In https://github.com/joyent/node/pulls/8695, the deprecation was removed from doc. This removes the deprecation from the code. PR-URL: nodejs/node-v0.x-archive#8700 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Adding note to api/modules.markdown about ability to load arbitrary path from modules from node_module path by adding reference to path after module name in call to require() PR-URL: nodejs/node-v0.x-archive#7794 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
Turn os.endianness() from a run-time function into a pure JS function. Upsides: makes it a good candidate for inlining at the call site. Downsides: none that I can think of. PR-URL: node-forward/node#55 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fix a Windows-only build error that was introduced in commit 1183ba4 ("zlib: support concatenated gzip files"). Rename the NO_ERROR and FAILED enumerations, they conflict with macros of the same name in <winerror.h>. PR-URL: node-forward/node#57 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Fix config option that doesn't work with OSX. Fixes: nodejs/node-v0.x-archive#8521 PR-URL: nodejs/node-v0.x-archive#8602 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
So what I did here is to make the icutools library actually contain the entire ICU dependencies needed for host-side tools. Sadly, this will build ICU twice, but avoids conflicts between host and target side. This all seems like a gyp bug of some sort, but without docs for toolsets, who’s to say? I removed the icuio library as a separate target, because it was only used by the host-side tools. PR-URL: nodejs/node-v0.x-archive#8681 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Note that this may not affect anything until powerpc support lands in v8. Related: https://github.com/srl295/node/issues/7 Related: srl295@ba8ab91 PR-URL: nodejs/node-v0.x-archive#8712 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
caineio
added
need info
and removed
wip
|
Oops, wrong branch. |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for the issue that f6e5740 had intended to fix.
It's needed because f6e5740 has been reverted in e24fa83.
See also https://github.com/node-forward/node/issues/20 and #100
@indutny or @bnoordhuis, can I get your review on this?