Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve https coverage to check create connection #11435

Closed
wants to merge 1 commit into from

Conversation

chiiia12
Copy link

@chiiia12 chiiia12 commented Feb 17, 2017

This PR improves https coverage (maybe cover statement 100%).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 17, 2017
@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Feb 17, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

socket.on('data', common.mustCall((chunk) => {
result += chunk;
}));
socket.on('end', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.mustCall() would be good here too

};

// use option connect
server.listen(0, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common.mustCall() here as well

});

// use port and host and option connect
server.listen(0, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and here :-)

@chiiia12
Copy link
Author

@jasnell thanks for reviewing! I fix it.

@yosuke-furukawa
Copy link
Member

LGTM.

@hiroppy
Copy link
Member

hiroppy commented Feb 24, 2017

hiroppy pushed a commit that referenced this pull request Mar 2, 2017
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@hiroppy
Copy link
Member

hiroppy commented Mar 2, 2017

landed in 104c9ac, thanks!

@hiroppy hiroppy closed this Mar 2, 2017
@bnoordhuis
Copy link
Member

See #11644, the test appears to be rather flaky.

addaleax pushed a commit that referenced this pull request Mar 5, 2017
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins
Copy link
Contributor

I've backported including the change that closed #11644

LMK if this should be reverted

MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
PR-URL: #11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
PR-URL: nodejs/node#11435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants