Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, url: URLSearchParams splits across lines #11428

Closed
wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Feb 16, 2017

The member methods of URLSearchParams should split across multiple lines with util.inspect depending on an option breakLength.

This test increases the coverage of internal/url.js:

The following line will be called:

Checklist
  • make -j4 test (UNIX) passes
  • tests are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,url

The member methods of URLSearchParams should split across multiple
lines with `util.inspect` depending on an option `breakLength`.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 16, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jasnell
Copy link
Member

jasnell commented Feb 16, 2017

@mscdex mscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 16, 2017
@targos
Copy link
Member

targos commented Feb 17, 2017

targos pushed a commit to targos/node that referenced this pull request Feb 18, 2017
The member methods of URLSearchParams should split across multiple
lines with `util.inspect` depending on an option `breakLength`.

PR-URL: nodejs#11428
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Feb 18, 2017

Landed in 8629b33

@targos targos closed this Feb 18, 2017
@watilde watilde deleted the url-breakLn branch February 18, 2017 16:33
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
The member methods of URLSearchParams should split across multiple
lines with `util.inspect` depending on an option `breakLength`.

PR-URL: nodejs#11428
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants